Re: [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure

2019-04-11 Thread Philippe Mathieu-Daudé
On 3/15/19 4:26 AM, Richard Henderson wrote: > There were 3 copies of this code, one of which used the wrong > data size for the failure indicator. Which, as the comment said, has never been called. Good cleanup. Reviewed-by: Philippe Mathieu-Daudé > Cc: Gerd Hoffmann > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure

2019-03-15 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 08:26:13PM -0700, Richard Henderson wrote: > There were 3 copies of this code, one of which used the wrong > data size for the failure indicator. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson > --- > ui/vnc.c | 37 +++-- > 1 fil

Re: [Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure

2019-03-15 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 08:26:13PM -0700, Richard Henderson wrote: > There were 3 copies of this code, one of which used the wrong > data size for the failure indicator. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson Reviewed-by: Gerd Hoffmann

[Qemu-devel] [PATCH v3 07/23] ui/vnc: Split out authentication_failure

2019-03-14 Thread Richard Henderson
There were 3 copies of this code, one of which used the wrong data size for the failure indicator. Cc: Gerd Hoffmann Signed-off-by: Richard Henderson --- ui/vnc.c | 37 +++-- 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c inde