Re: [Qemu-devel] [PATCH v3 07/10] spice: add keyboard

2010-08-26 Thread Anthony Liguori
On 08/26/2010 01:55 AM, Gerd Hoffmann wrote: Hi, + + qemu_spice_input_init(); Why not pass spice_server to qemu_spice_input_init() and avoid the global? We need the global anyway for the guest devices (not yet in this series). They are created using -device. Thus the initialization

Re: [Qemu-devel] [PATCH v3 07/10] spice: add keyboard

2010-08-25 Thread Gerd Hoffmann
Hi, + + qemu_spice_input_init(); Why not pass spice_server to qemu_spice_input_init() and avoid the global? We need the global anyway for the guest devices (not yet in this series). They are created using -device. Thus the initialization functions are not called from spice code and we

Re: [Qemu-devel] [PATCH v3 07/10] spice: add keyboard

2010-08-25 Thread Anthony Liguori
On 08/25/2010 09:19 AM, Gerd Hoffmann wrote: Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.ob

[Qemu-devel] [PATCH v3 07/10] spice: add keyboard

2010-08-25 Thread Gerd Hoffmann
Open keyboard channel. Now you can type into the spice client and the keyboard events are sent to your guest. You'll need some other display like vnc to actually see the guest responding to them though. Signed-off-by: Gerd Hoffmann --- Makefile.objs|2 +- ui/qemu-spice.h |1 + ui/