Re: [Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-19 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 02:43:53PM +0100, Paolo Bonzini wrote: > Before: > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo > Failed to parse URL : foo > qemu-io-old: can't open device (null): Could not open 'foo': Invalid > argument > > After: > $

[Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-17 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $ ./qemu-io qemu-io> open -r -o file.driver=iscsi,file.filename=foo qemu-i

[Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-14 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $ ./qemu-io qemu-io> open -r -o file.driver=iscsi,file.filename=foo qemu-i