Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-21 Thread Eduardo Habkost
On Wed, Jun 21, 2017 at 11:00:54AM +0800, Peter Xu wrote: > On Tue, Jun 20, 2017 at 11:07:34AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 20, 2017 at 09:55:03PM +0800, Peter Xu wrote: > > > On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: [...] > > > > > > > > Another thing wor

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-20 Thread Peter Xu
On Tue, Jun 20, 2017 at 11:07:34AM -0300, Eduardo Habkost wrote: > On Tue, Jun 20, 2017 at 09:55:03PM +0800, Peter Xu wrote: > > On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: [...] > > > This is where things get tricky and fragile: the translation from > > > -cpu to global prop

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-20 Thread Eduardo Habkost
On Tue, Jun 20, 2017 at 09:55:03PM +0800, Peter Xu wrote: > On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 19, 2017 at 08:49:41PM +0800, Peter Xu wrote: > > > Let KVM be the first user of the new AccelState.global_props field. > > > Basically kvm accel only contain

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-20 Thread Peter Xu
On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: > On Mon, Jun 19, 2017 at 08:49:41PM +0800, Peter Xu wrote: > > Let KVM be the first user of the new AccelState.global_props field. > > Basically kvm accel only contains accel props for TYPE_X86_CPUs but not > > anything else yet. > >

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-19 Thread Eduardo Habkost
On Mon, Jun 19, 2017 at 08:49:41PM +0800, Peter Xu wrote: > Let KVM be the first user of the new AccelState.global_props field. > Basically kvm accel only contains accel props for TYPE_X86_CPUs but not > anything else yet. > > There will be a change on how these global properties are applied for >

[Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

2017-06-19 Thread Peter Xu
Let KVM be the first user of the new AccelState.global_props field. Basically kvm accel only contains accel props for TYPE_X86_CPUs but not anything else yet. There will be a change on how these global properties are applied for TYPE_X86_CPU devices. The general workflow of the global property stu