Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 06:54:54PM +1000, Peter Crosthwaite wrote: > On Mon, Jun 9, 2014 at 12:44 PM, Hu Tao wrote: > > On Fri, Jun 06, 2014 at 02:48:15PM +0200, Igor Mammedov wrote: > >> On Fri, 6 Jun 2014 17:29:38 +0800 > >> Hu Tao wrote: > >> > >> > On Fri, May 30, 2014 at 09:59:55AM +0200, Ig

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-09 Thread Peter Crosthwaite
On Mon, Jun 9, 2014 at 12:44 PM, Hu Tao wrote: > On Fri, Jun 06, 2014 at 02:48:15PM +0200, Igor Mammedov wrote: >> On Fri, 6 Jun 2014 17:29:38 +0800 >> Hu Tao wrote: >> >> > On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote: >> > > On Fri, 30 May 2014 00:05:51 +1000 >> > > Peter Crost

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-09 Thread Hu Tao
On Mon, Jun 09, 2014 at 10:44:02AM +0800, Hu Tao wrote: > On Fri, Jun 06, 2014 at 02:48:15PM +0200, Igor Mammedov wrote: > > On Fri, 6 Jun 2014 17:29:38 +0800 > > Hu Tao wrote: > > > > > On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote: > > > > On Fri, 30 May 2014 00:05:51 +1000 > >

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-08 Thread Hu Tao
On Fri, Jun 06, 2014 at 02:48:15PM +0200, Igor Mammedov wrote: > On Fri, 6 Jun 2014 17:29:38 +0800 > Hu Tao wrote: > > > On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote: > > > On Fri, 30 May 2014 00:05:51 +1000 > > > Peter Crosthwaite wrote: > > > > > > > On Tue, May 27, 2014 at 1

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-06 Thread Igor Mammedov
On Fri, 6 Jun 2014 17:29:38 +0800 Hu Tao wrote: > On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote: > > On Fri, 30 May 2014 00:05:51 +1000 > > Peter Crosthwaite wrote: > > > > > On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov > > > wrote: > > > > Provides framework for splitting

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-06-06 Thread Hu Tao
On Fri, May 30, 2014 at 09:59:55AM +0200, Igor Mammedov wrote: > On Fri, 30 May 2014 00:05:51 +1000 > Peter Crosthwaite wrote: > > > On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > > > Provides framework for splitting host RAM allocation/ > > > policies into a separate backend that coul

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-30 Thread Igor Mammedov
On Fri, 30 May 2014 10:21:04 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Thu, 29 May 2014 10:41:32 -0600 > > Eric Blake wrote: > > > >> On 05/27/2014 07:01 AM, Igor Mammedov wrote: > [...] > >> > +goto out; > >> > +} > >> > +if (!value) { > >> > +err

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-30 Thread Markus Armbruster
Igor Mammedov writes: > On Thu, 29 May 2014 10:41:32 -0600 > Eric Blake wrote: > >> On 05/27/2014 07:01 AM, Igor Mammedov wrote: [...] >> > +goto out; >> > +} >> > +if (!value) { >> > +error_setg(&local_err, "Property '%s.%s' doesn't take value '%" >> > +

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-30 Thread Igor Mammedov
On Thu, 29 May 2014 10:41:32 -0600 Eric Blake wrote: > On 05/27/2014 07:01 AM, Igor Mammedov wrote: > > Provides framework for splitting host RAM allocation/ > > policies into a separate backend that could be used > > by devices. > > > > Initially only legacy RAM backend is provided, which > > u

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-30 Thread Igor Mammedov
On Fri, 30 May 2014 00:05:51 +1000 Peter Crosthwaite wrote: > On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > > Provides framework for splitting host RAM allocation/ > > policies into a separate backend that could be used > > by devices. > > > > Initially only legacy RAM backend is prov

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-29 Thread Eric Blake
On 05/27/2014 07:01 AM, Igor Mammedov wrote: > Provides framework for splitting host RAM allocation/ > policies into a separate backend that could be used > by devices. > > Initially only legacy RAM backend is provided, which > uses memory_region_init_ram() allocator and compatible > with every CL

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-29 Thread Peter Crosthwaite
On Fri, May 30, 2014 at 1:25 AM, Paolo Bonzini wrote: > Il 29/05/2014 16:05, Peter Crosthwaite ha scritto: > >>> > +path = object_get_canonical_path_component(OBJECT(backend)); >>> > +memory_region_init_ram(&backend->mr, OBJECT(backend), path, >> >> Passing the full canonical path as the n

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-29 Thread Paolo Bonzini
Il 29/05/2014 17:39, Peter Crosthwaite ha scritto: > It's not the full canonical path, it's basically the id. > Fair enough. Although its still redundant though isn't it? Should we ever clean up messages etc in memory api to include both owner and name this is going to come out: "foo/bar/baz:b

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-29 Thread Paolo Bonzini
Il 29/05/2014 16:05, Peter Crosthwaite ha scritto: > +path = object_get_canonical_path_component(OBJECT(backend)); > +memory_region_init_ram(&backend->mr, OBJECT(backend), path, Passing the full canonical path as the name of memory region is redundant as that information is already passe

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-29 Thread Peter Crosthwaite
On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > Provides framework for splitting host RAM allocation/ > policies into a separate backend that could be used > by devices. > > Initially only legacy RAM backend is provided, which > uses memory_region_init_ram() allocator and compatible > wit

[Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

2014-05-27 Thread Igor Mammedov
Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and compatible with every CLI option that affects memory_region_init_ram(). Signed-off