Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:41 PM, Marc-André Lureau wrote: On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev wrote: lets consider this patch. You have done 2 things: - changed initialisation order and dropped nasty temporary variables - introduced alloc/free code But in the next patch each line with alloc

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Marc-André Lureau
On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev wrote: > lets consider this patch. You have done 2 things: > - changed initialisation order and dropped nasty temporary variables > - introduced alloc/free code > > But in the next patch each line with alloc/free code > will be changed due to variabl

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 09:17 PM, Marc-André Lureau wrote: Hi - Original Message - On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau A following patch will return allocated string. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- qga/main.c

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Marc-André Lureau
Hi - Original Message - > On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > A following patch will return allocated string. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Michael Roth > > --- > > qga/main.c | 57 +

Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread Denis V. Lunev
On 08/26/2015 01:05 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau A following patch will return allocated string. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- qga/main.c | 57 +++-- 1 file changed, 31 i

[Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

2015-08-26 Thread marcandre . lureau
From: Marc-André Lureau A following patch will return allocated string. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth --- qga/main.c | 57 +++-- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/qga/main.c b/qga/ma