Re: [Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset()

2019-05-30 Thread Peter Xu
On Thu, May 30, 2019 at 12:05:27PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > These helpers copy the source bitmap to destination bitmap with a > > shift either on the src or dst bitmap. > > > > Meanwhile, we never have bitmap tests but we should. > > > > Thi

Re: [Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset()

2019-05-30 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > These helpers copy the source bitmap to destination bitmap with a > shift either on the src or dst bitmap. > > Meanwhile, we never have bitmap tests but we should. > > This patch also introduces the initial test cases for utils/bitmap.c > but it only tests

[Qemu-devel] [PATCH v3 05/12] bitmap: Add bitmap_copy_with_{src|dst}_offset()

2019-05-30 Thread Peter Xu
These helpers copy the source bitmap to destination bitmap with a shift either on the src or dst bitmap. Meanwhile, we never have bitmap tests but we should. This patch also introduces the initial test cases for utils/bitmap.c but it only tests the newly introduced functions. Signed-off-by: Pete