Re: [Qemu-devel] [PATCH v3 05/10] slirp: switch to GPollFD

2013-02-06 Thread Stefan Hajnoczi
On Wed, Feb 06, 2013 at 01:59:25AM +0100, Laszlo Ersek wrote: > comments in-line > > On 02/04/13 13:12, Stefan Hajnoczi wrote: > > @@ -475,15 +490,15 @@ void slirp_select_poll(fd_set *readfds, fd_set > > *writefds, fd_set *xfds, > > /* > > * Check for URG data >

Re: [Qemu-devel] [PATCH v3 05/10] slirp: switch to GPollFD

2013-02-05 Thread Laszlo Ersek
comments in-line On 02/04/13 13:12, Stefan Hajnoczi wrote: > Slirp uses rfds/wfds/xfds more extensively than other QEMU components. > > The rarely-used out-of-band TCP data feature is used. That means we > need the full table of select(2) to g_poll(3) events: > > rfds -> G_IO_IN | G_IO_HUP |

[Qemu-devel] [PATCH v3 05/10] slirp: switch to GPollFD

2013-02-04 Thread Stefan Hajnoczi
Slirp uses rfds/wfds/xfds more extensively than other QEMU components. The rarely-used out-of-band TCP data feature is used. That means we need the full table of select(2) to g_poll(3) events: rfds -> G_IO_IN | G_IO_HUP | G_IO_ERR wfds -> G_IO_OUT | G_IO_ERR xfds -> G_IO_PRI I came up wit