Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Use packed structure instead of pointer arithmetics. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 6 ++ > nbd/server.c| 36 ++-- > 2 files changed, 20 inser

Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Eric Blake
On 10/12/2017 04:42 PM, Eric Blake wrote: > On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Use packed structure instead of pointer arithmetics. > >> +set_be_simple_reply(&simple_reply, >> system_errno_to_nbd_errno(reply->error), >> +reply->handle); >>

Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Use packed structure instead of pointer arithmetics. English is fun! In the subject line, I'm fairly certain that "structurize" is not likely to be in any dictionary, yet it is a perfect word describing the patch, so I'm not touching i

[Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Use packed structure instead of pointer arithmetics. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 6 ++ nbd/server.c| 36 ++-- 2 files changed, 20 insertions(+), 22 deletions(-) diff --git a/include/block/nbd.h b/include/bloc