Re: [Qemu-devel] [PATCH v3 03/18] qapi: Factor out JSON string escaping

2016-05-03 Thread Markus Armbruster
Eric Blake writes: > On 04/29/2016 06:09 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Pull out a new qstring_append_json_string() helper, so that all >>> JSON output producers can use the same output escaping rules. >>> >>> While it appears that vmstate's use of the simpler qjson.c

Re: [Qemu-devel] [PATCH v3 03/18] qapi: Factor out JSON string escaping

2016-04-29 Thread Eric Blake
On 04/29/2016 06:09 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Pull out a new qstring_append_json_string() helper, so that all >> JSON output producers can use the same output escaping rules. >> >> While it appears that vmstate's use of the simpler qjson.c >> formatter is not currentl

Re: [Qemu-devel] [PATCH v3 03/18] qapi: Factor out JSON string escaping

2016-04-29 Thread Markus Armbruster
Eric Blake writes: > Pull out a new qstring_append_json_string() helper, so that all > JSON output producers can use the same output escaping rules. > > While it appears that vmstate's use of the simpler qjson.c > formatter is not currently encountering any string that needs > escapes to be valid

[Qemu-devel] [PATCH v3 03/18] qapi: Factor out JSON string escaping

2016-04-28 Thread Eric Blake
Pull out a new qstring_append_json_string() helper, so that all JSON output producers can use the same output escaping rules. While it appears that vmstate's use of the simpler qjson.c formatter is not currently encountering any string that needs escapes to be valid JSON, it is better to be safe t