Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Alexander Graf
On 19.05.14 22:33, Peter Crosthwaite wrote: On Tue, May 20, 2014 at 2:50 AM, Richard Henderson wrote: On 05/19/2014 09:45 AM, Marc Marí wrote: This STDOUT vs _log() choice is a bit irregular, and I think you might be better off abandoning it completely. Richard, Alex, do we really need to opt

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Peter Crosthwaite
On Tue, May 20, 2014 at 2:50 AM, Richard Henderson wrote: > On 05/19/2014 09:45 AM, Marc Marí wrote: >>> > This STDOUT vs _log() choice is a bit irregular, and I think you might >>> > be better off abandoning it completely. Richard, Alex, do we really >>> > need to optionally route printfery to lo

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Richard Henderson
On 05/19/2014 09:45 AM, Marc Marí wrote: >> > This STDOUT vs _log() choice is a bit irregular, and I think you might >> > be better off abandoning it completely. Richard, Alex, do we really >> > need to optionally route printfery to log or stderr? (considering _log >> > is NOW stderr by default now

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Marc Marí
El Sun, 18 May 2014 19:37:12 +1000 Peter Crosthwaite escribió: > On Sun, May 18, 2014 at 9:03 AM, Marc Marí > wrote: > > Modify debug macros to have the same format through the codebase > > and use regular ifs instead of ifdef. > > > > Signed-off-by: Marc Marí > > --- > > hw/s390x/s390-virtio-b

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-19 Thread Alexander Graf
On 18.05.14 11:37, Peter Crosthwaite wrote: On Sun, May 18, 2014 at 9:03 AM, Marc Marí wrote: Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- hw/s390x/s390-virtio-bus.c |9 + hw/s390x/s390-virt

Re: [Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-18 Thread Peter Crosthwaite
On Sun, May 18, 2014 at 9:03 AM, Marc Marí wrote: > Modify debug macros to have the same format through the codebase and use > regular > ifs instead of ifdef. > > Signed-off-by: Marc Marí > --- > hw/s390x/s390-virtio-bus.c |9 + > hw/s390x/s390-virtio.c |9 + > targe

[Qemu-devel] [PATCH v3 03/16] s390: Convert debug printfs to QEMU_DPRINTF

2014-05-17 Thread Marc Marí
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. Signed-off-by: Marc Marí --- hw/s390x/s390-virtio-bus.c |9 + hw/s390x/s390-virtio.c |9 + target-s390x/helper.c | 23 +++ target-s390x/kv