Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-31 Thread Eric Blake
On 07/31/2017 03:20 AM, Markus Armbruster wrote: >>> It's not "worse", it's just different :) >>> >>> Suggest: >> >> "Mikey likes it" (no idea if that pop culture reference from my >> childhood has broader range than the US) > > 'fraid I'm out of range :) It's not fair of me to leave you hangin

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-31 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2017 01:32 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> We have two flavors of vararg usage in qtest; make it clear that >>> qmp() has different semantics than hmp(), and let the compiler >>> enforce that hmp() is used correctly. However, qmp() (and fr

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-28 Thread Eric Blake
On 07/28/2017 01:32 PM, Markus Armbruster wrote: > Eric Blake writes: > >> We have two flavors of vararg usage in qtest; make it clear that >> qmp() has different semantics than hmp(), and let the compiler >> enforce that hmp() is used correctly. However, qmp() (and friends) >> only accept a subs

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-28 Thread Markus Armbruster
Eric Blake writes: > We have two flavors of vararg usage in qtest; make it clear that > qmp() has different semantics than hmp(), and let the compiler > enforce that hmp() is used correctly. However, qmp() (and friends) > only accept a subset of printf flags look-alikes (namely, those > that our

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-28 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 04:15:14PM -0500, Eric Blake wrote: > We have two flavors of vararg usage in qtest; make it clear that > qmp() has different semantics than hmp(), and let the compiler > enforce that hmp() is used correctly. However, qmp() (and friends) > only accept a subset of printf flags

[Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-25 Thread Eric Blake
We have two flavors of vararg usage in qtest; make it clear that qmp() has different semantics than hmp(), and let the compiler enforce that hmp() is used correctly. However, qmp() (and friends) only accept a subset of printf flags look-alikes (namely, those that our JSON parser understands), and w