Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 16:53, Peter Maydell ha scritto: >> This will break running BE32 binaries with "-cpu any" >> (which sets all the features we know about, including >> ARM_FEATURE_V7). > > Yes, this was on purpose. I would expect that anybody running BE32 binaries is probably running them with -cpu

Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-26 Thread Peter Maydell
On 26 June 2014 15:15, Paolo Bonzini wrote: > Il 26/06/2014 16:01, Peter Maydell ha scritto: >> On 21 June 2014 13:58, Paolo Bonzini wrote: >>> bswap_code is a CPU property of sorts ("is the iside endianness the >>> opposite way round to TARGET_WORDS_BIGENDIAN?") but it is not the >>> actual CPU

Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 16:01, Peter Maydell ha scritto: > On 21 June 2014 13:58, Paolo Bonzini wrote: >> bswap_code is a CPU property of sorts ("is the iside endianness the >> opposite way round to TARGET_WORDS_BIGENDIAN?") but it is not the >> actual CPU state involved here which is SCTLR.B (set for BE32

Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-26 Thread Peter Maydell
On 21 June 2014 13:58, Paolo Bonzini wrote: > bswap_code is a CPU property of sorts ("is the iside endianness the > opposite way round to TARGET_WORDS_BIGENDIAN?") but it is not the > actual CPU state involved here which is SCTLR.B (set for BE32 > binaries, clear for BE8). > > Replace bswap_code w

[Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-21 Thread Paolo Bonzini
bswap_code is a CPU property of sorts ("is the iside endianness the opposite way round to TARGET_WORDS_BIGENDIAN?") but it is not the actual CPU state involved here which is SCTLR.B (set for BE32 binaries, clear for BE8). Replace bswap_code with SCTLR.B, and pass that to arm_ld*_code. The next pat