Re: [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields

2013-08-05 Thread Fam Zheng
On Mon, 08/05 23:30, Jeff Cody wrote: > On Tue, Aug 06, 2013 at 09:40:36AM +0800, Fam Zheng wrote: > > The size and offset fields are all non-negative values, use uint64_t for > > them to avoid getting negative in memory value by int overflow. > > > > Signed-off-by: Fam Zheng > > --- > > block/v

Re: [Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields

2013-08-05 Thread Jeff Cody
On Tue, Aug 06, 2013 at 09:40:36AM +0800, Fam Zheng wrote: > The size and offset fields are all non-negative values, use uint64_t for > them to avoid getting negative in memory value by int overflow. > > Signed-off-by: Fam Zheng > --- > block/vmdk.c | 16 > 1 file changed, 8 ins

[Qemu-devel] [PATCH v3 03/10] vmdk: use unsigned values for on disk header fields

2013-08-05 Thread Fam Zheng
The size and offset fields are all non-negative values, use uint64_t for them to avoid getting negative in memory value by int overflow. Signed-off-by: Fam Zheng --- block/vmdk.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c inde