ecember 13, 2011 2:45 AM
To: Evgeny Voevodin
Cc: qemu-devel@nongnu.org; m.koz...@samsung.com; d.solod...@samsung.com
Subject: Re: [Qemu-devel] [PATCH v3 02/14] ARM: exynos4210: CMU support
On 12 December 2011 06:43, Evgeny Voevodin wrote:
> From: Maksim Kozlov
>
> Add exynos4210 Clock
On 14 December 2011 17:08, Maksim E. Kozlov wrote:
>>> +
>>> +/*
>>> + * There are five CMUs:
>>> + *
>>> + * CMU_LEFTBUS
>>> + * CMU_RIGHTBUS
>>> + * CMU_TOP
>>> + * CMU_DMC
>>> + * CMU_CPU
>>> + *
>>> + * each of them uses 16KB address space for SFRs
>>> + *
>>> + * + 0x4000 because SFR r
+
+/*
+ * There are five CMUs:
+ *
+ * CMU_LEFTBUS
+ * CMU_RIGHTBUS
+ * CMU_TOP
+ * CMU_DMC
+ * CMU_CPU
+ *
+ * each of them uses 16KB address space for SFRs
+ *
+ * + 0x4000 because SFR region for CMUs starts at 0x1003,
+ * but the first CMU (CMU_LEFTBUS) starts with this offset
+ *
+
On 14 December 2011 12:10, Maksim E. Kozlov wrote:
> Should we save globally defined static structures , some fields of which can
> be changed at runtime? If yes, could you recommend a right way to do that?
You shouldn't have globally defined static structures or variables which
can be changed at
+
+static const VMStateDescription vmstate_exynos4210_cmu = {
+.name = "exynos4210.cmu",
+.version_id = 1,
+.minimum_version_id = 1,
+.minimum_version_id_old = 1,
+.fields = (VMStateField[]) {
+/*
+ * TODO: Maybe we should save Exynos4210CmuC
From: Maksim Kozlov
Add exynos4210 Clock Management Units emulation
Signed-off-by: Evgeny Voevodin
---
Makefile.target |2 +-
hw/exynos4210.c |7 +
hw/exynos4210.h | 22 +
hw/exynos4210_cmu.c | 1146 +++
4 files changed, 117
