Re: [Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

2015-12-17 Thread Markus Armbruster
John Snow writes: > On 12/17/2015 02:53 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Modify this function to operate directly on FDrive objects instead of >>> unpacking and passing all of those parameters manually. >>> >>> Helps reduce complexity in each caller, and reduces the numb

Re: [Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

2015-12-17 Thread John Snow
On 12/17/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: > >> Modify this function to operate directly on FDrive objects instead of >> unpacking and passing all of those parameters manually. >> >> Helps reduce complexity in each caller, and reduces the number of args. > > For now,

Re: [Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

2015-12-16 Thread Markus Armbruster
John Snow writes: > Modify this function to operate directly on FDrive objects instead of > unpacking and passing all of those parameters manually. > > Helps reduce complexity in each caller, and reduces the number of args. For now, there's just one. Diffstat suggests it's an overall simplifica

[Qemu-devel] [PATCH v3 02/11] fdc: refactor pick_geometry

2015-12-16 Thread John Snow
Modify this function to operate directly on FDrive objects instead of unpacking and passing all of those parameters manually. Helps reduce complexity in each caller, and reduces the number of args. Signed-off-by: John Snow --- hw/block/fdc.c | 54 +++-