Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Jon Doron
Hi Alex, Thank you for your comments I will add a cover-letter and update it with the review changes, as for what I'm was hoping to add later on is mostly custom query commands for KVM perhaps might apply to other architectures as well here are things i had mind: 1. Get VM nested state, this way y

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Jon Doron
Thank you Alex I will publish v8 with fixes from your review :) please see my comments below On Thu, Apr 25, 2019 at 5:42 PM Alex Bennée wrote: > > > ari...@gmail.com writes: > > > From: Jon Doron > > > > Signed-off-by: Jon Doron > > --- > > gdbstub.c | 215

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Alex Bennée
ari...@gmail.com writes: > From: Jon Doron > > Signed-off-by: Jon Doron Multi-patch series should have a cover letter: https://wiki.qemu.org/index.php/Contribute/SubmitAPatch#Include_a_meaningful_cover_letter Overall this looks like a nice improvement to the parsing code. Please CC me on

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-25 Thread Alex Bennée
ari...@gmail.com writes: > From: Jon Doron > > Signed-off-by: Jon Doron > --- > gdbstub.c | 215 ++ > 1 file changed, 215 insertions(+) > > diff --git a/gdbstub.c b/gdbstub.c > index d54abd17cc..b5bd01b913 100644 > --- a/gdbstub.c > +++ b/gd

Re: [Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-24 Thread Richard Henderson
On 4/24/19 7:26 AM, ari...@gmail.com wrote: > +static const char *cmd_next_param(const char *param, const char delimiter) > +{ > +const char *delim; > +static char all_delimiters[] = ",;:="; static const char > +static char no_delimiter[] = "\0"; > +char curr_delimiters[2] = {0};

[Qemu-devel] [PATCH v3 01/20] gdbstub: Add infrastructure to parse cmd packets

2019-04-24 Thread arilou
From: Jon Doron Signed-off-by: Jon Doron --- gdbstub.c | 215 ++ 1 file changed, 215 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d54abd17cc..b5bd01b913 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1268,6 +1268,221 @@ out: return