Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-17 Thread Kevin Wolf
Am 15.06.2019 um 22:31 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > monitor.c mixes a lot of different things in a single file: The core > >> > monitor infrastructure, HMP infrastrctur

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > monitor.c mixes a lot of different things in a single file: The core >> > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the >> > implementation of several HMP and QM

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-14 Thread Kevin Wolf
Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > monitor.c mixes a lot of different things in a single file: The core > > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > > implementation of several HMP and QMP commands. Almost worse, st

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-14 Thread Markus Armbruster
Kevin Wolf writes: > monitor.c mixes a lot of different things in a single file: The core > monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the > implementation of several HMP and QMP commands. Almost worse, struct > Monitor mixes state for HMP, for QMP, and state actually shar

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190613153405.24769-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190613153405.24769-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c

[Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-13 Thread Kevin Wolf
monitor.c mixes a lot of different things in a single file: The core monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the implementation of several HMP and QMP commands. Almost worse, struct Monitor mixes state for HMP, for QMP, and state actually shared between all monitors. moni