Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Alex Bennée
Paolo Bonzini writes: > On 14/07/2016 14:02, Alex Bennée wrote: >> Looking at the perf data it looks like the hotest part of the code now >> is cpu_get_tb_cpu_state which is required to get the initial hash to >> search for the next tb. > > It should be possible to keep the flags up-to-date in a

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Paolo Bonzini
On 14/07/2016 14:02, Alex Bennée wrote: > Looking at the perf data it looks like the hotest part of the code now > is cpu_get_tb_cpu_state which is required to get the initial hash to > search for the next tb. It should be possible to keep the flags up-to-date in a separate field of CPUARMState,

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Alex Bennée
Paolo Bonzini writes: > On 12/07/2016 22:13, Sergey Fedorov wrote: >> From: Sergey Fedorov > > Have you measured performance with the series? In any case, it's nice > to see MTTCG finally taking shape! Here are some numbers on the multi-threaded pigz test: Before: retry.py called with ['./

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Sergey Fedorov
On 14/07/16 12:55, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 13/07/16 10:39, Paolo Bonzini wrote: >>> Have you measured performance with the series? In any case, it's nice >>> to see MTTCG finally taking shape! >> No, I didn't measured the performance. Maybe Alex can help me with >> thi

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-14 Thread Alex Bennée
Sergey Fedorov writes: > On 13/07/16 10:39, Paolo Bonzini wrote: >> On 12/07/2016 22:13, Sergey Fedorov wrote: >>> From: Sergey Fedorov >>> >>> Hi, >>> >>> This is my respin of Alex's v2 series [1]. >>> >>> The first 8 patches are preparation for the patch 9, the subject matter >>> of this seri

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-13 Thread Sergey Fedorov
On 13/07/16 10:39, Paolo Bonzini wrote: > If anything, for historical reasons one might rename tb_find_physical to > tb_find_slow and leave the tb_find_fast name, but I think the patch is > good as is. I think tb_find_htable() or tb_find_global_htable() could also be good options if we're going to

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-13 Thread Sergey Fedorov
On 13/07/16 10:39, Paolo Bonzini wrote: > On 12/07/2016 22:13, Sergey Fedorov wrote: >> From: Sergey Fedorov >> >> Hi, >> >> This is my respin of Alex's v2 series [1]. >> >> The first 8 patches are preparation for the patch 9, the subject matter >> of this series, which enables lockless translatio

Re: [Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-13 Thread Paolo Bonzini
On 12/07/2016 22:13, Sergey Fedorov wrote: > From: Sergey Fedorov > > Hi, > > This is my respin of Alex's v2 series [1]. > > The first 8 patches are preparation for the patch 9, the subject matter > of this series, which enables lockless translation block lookup. The > main change here is tha

[Qemu-devel] [PATCH v3 00/11] Reduce lock contention on TCG hot-path

2016-07-12 Thread Sergey Fedorov
From: Sergey Fedorov Hi, This is my respin of Alex's v2 series [1]. The first 8 patches are preparation for the patch 9, the subject matter of this series, which enables lockless translation block lookup. The main change here is that Paolo's suggestion is implemented: TBs are marked with invali