Re: [Qemu-devel] [PATCH v3 0/7] Runtime pagesize computation

2016-10-11 Thread Richard Henderson
On 10/11/2016 03:18 PM, Peter Maydell wrote: On 11 October 2016 at 12:20, Richard Henderson wrote: On 10/11/2016 12:08 PM, Peter Maydell wrote: I would ideally have liked to finalize things much later, but this is in practice hugely difficult because so many things (in particular all the addre

Re: [Qemu-devel] [PATCH v3 0/7] Runtime pagesize computation

2016-10-11 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1476205699-28857-1-git-send-email-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH v3 0/7] Runtime pagesize computation Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v3 0/7] Runtime pagesize computation

2016-10-11 Thread Peter Maydell
On 11 October 2016 at 12:20, Richard Henderson wrote: > On 10/11/2016 12:08 PM, Peter Maydell wrote: >> I would ideally have liked to finalize things much later, but >> this is in practice hugely difficult because so many things >> (in particular all the address space/memory system code) >> assume

Re: [Qemu-devel] [PATCH v3 0/7] Runtime pagesize computation

2016-10-11 Thread Richard Henderson
On 10/11/2016 12:08 PM, Peter Maydell wrote: The basic idea here is that: * the target CPU implementation has to opt into variable page size by defining TARGET_PAGE_BITS_VARY, and then calling set_preferred_target_page_bits() in its realize function with whatever the CPU as instantiated

[Qemu-devel] [PATCH v3 0/7] Runtime pagesize computation

2016-10-11 Thread Peter Maydell
(I posted version 2 way back in June...) The basic idea here is that: * the target CPU implementation has to opt into variable page size by defining TARGET_PAGE_BITS_VARY, and then calling set_preferred_target_page_bits() in its realize function with whatever the CPU as instantiated actu