Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-25 Thread Marc-André Lureau
Hi On Mon, Mar 16, 2015 at 6:19 PM, Paolo Bonzini wrote: > On 16/03/2015 17:52, Jeremy White wrote: >> It seemed as though the convention was that all non static functions >> went into the .syms file; I may have misunderstood. > > I suspect that the .syms file was introduced as a way to hide util

Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-16 Thread Paolo Bonzini
On 16/03/2015 17:52, Jeremy White wrote: > It seemed as though the convention was that all non static functions > went into the .syms file; I may have misunderstood. I suspect that the .syms file was introduced as a way to hide utility functions from libqemuutil.a. Now that libqemuutil is not u

Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-16 Thread Jeremy White
Hey Marc-André, Thanks for the review. On 03/16/2015 11:22 AM, Marc-André Lureau wrote: > Hi Jeremy > > I have checked no regression for spice, but not the new pcsc backend. > Do you have a spice-gtk branch or are you using vscclient only? I'm using spice-gtk with this patch: http://lists.fre

Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-16 Thread Marc-André Lureau
Hi Jeremy I have checked no regression for spice, but not the new pcsc backend. Do you have a spice-gtk branch or are you using vscclient only? I would feel better note polluting more the exported symbols from libcacard. For ex, vcard_init() and cac_card_init() are already quite useless, since th

Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-13 Thread Patchew Tool
This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log: http://qemu.patchew.org/testing/log/<1426275924-1904-1-git-send-email-jwh...@codeweavers.com> --8<- total: 0 errors, 0 warning

[Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard

2015-03-13 Thread Jeremy White
This is a resend of my outstanding patches, gathered together as one series. I'm hoping to agitate for this whole set to be considered. Changes since v2: * Include outstanding patches not strictly related to passthru mode * Include a fix for read binary transactions * Mitigate some performa