Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize

2016-07-23 Thread Corey Minyard
On 07/23/2016 10:16 AM, Paolo Bonzini wrote: On 23/07/2016 15:18, Corey Minyard wrote: On 07/23/2016 02:46 AM, Paolo Bonzini wrote: On 22/07/2016 21:50, miny...@acm.org wrote: This has kind of opened a can of worms for me, though. Looking at a lot of the devices, there is no unrealize functi

Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize

2016-07-23 Thread Paolo Bonzini
On 23/07/2016 15:18, Corey Minyard wrote: > On 07/23/2016 02:46 AM, Paolo Bonzini wrote: >> >> On 22/07/2016 21:50, miny...@acm.org wrote: >>> This has kind of opened a can of worms for me, though. Looking >>> at a lot of the devices, there is no unrealize function and that >>> can leave a lot o

Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize

2016-07-23 Thread Corey Minyard
On 07/23/2016 02:46 AM, Paolo Bonzini wrote: On 22/07/2016 21:50, miny...@acm.org wrote: This has kind of opened a can of worms for me, though. Looking at a lot of the devices, there is no unrealize function and that can leave a lot of things hanging. And for ISA bus devices, there is no way

Re: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize

2016-07-23 Thread Paolo Bonzini
On 22/07/2016 21:50, miny...@acm.org wrote: > > This has kind of opened a can of worms for me, though. Looking > at a lot of the devices, there is no unrealize function and that > can leave a lot of things hanging. And for ISA bus devices, there > is no way to unregister ports. Right, this i

[Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize

2016-07-22 Thread minyard
Changes from v2: Set the timers to NULL when unrealizing them, as the data structure is still intact. Split out the removal of the mutex from ipmi_bmc_sim to its own patch. I did figure out a way to test these. You can set the realize bool in the qapi for the device to cause it to be realized/