Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-21 Thread Markus Armbruster
Orit Wasserman writes: > On 09/20/2012 04:19 PM, Markus Armbruster wrote: >> Orit Wasserman writes: >> >>> Changes from v2: >>> - remove the use of getnameinfo >>> - remove errp for inet_connect_addr >>> - remove QemuOpt "block" >>> - fix errors in wait_for_connect >>> - pa

Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-20 Thread Michael S. Tsirkin
On Thu, Sep 20, 2012 at 05:12:41PM +0200, Paolo Bonzini wrote: > Il 20/09/2012 16:55, Orit Wasserman ha scritto: > > > Almost there for connect. > > > > > > I'm afraid we have a similar problem with listen: we bind only on the > > > first address that works. Shouldn't we bind all of them? > > >

Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-20 Thread Michael S. Tsirkin
On Thu, Sep 20, 2012 at 05:55:14PM +0300, Orit Wasserman wrote: > On 09/20/2012 04:19 PM, Markus Armbruster wrote: > > Orit Wasserman writes: > > > >> Changes from v2: > >>- remove the use of getnameinfo > >>- remove errp for inet_connect_addr > >>- remove QemuOpt "block" > >>- fi

Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-20 Thread Paolo Bonzini
Il 20/09/2012 16:55, Orit Wasserman ha scritto: > > Almost there for connect. > > > > I'm afraid we have a similar problem with listen: we bind only on the > > first address that works. Shouldn't we bind all of them? > > > > http://www.akkadia.org/drepper/userapi-ipv6.html > > yes listen should

Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-20 Thread Orit Wasserman
On 09/20/2012 04:19 PM, Markus Armbruster wrote: > Orit Wasserman writes: > >> Changes from v2: >> - remove the use of getnameinfo >> - remove errp for inet_connect_addr >> - remove QemuOpt "block" >> - fix errors in wait_for_connect >> - pass ConnectState as a parameter

Re: [Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-20 Thread Markus Armbruster
Orit Wasserman writes: > Changes from v2: > - remove the use of getnameinfo > - remove errp for inet_connect_addr > - remove QemuOpt "block" > - fix errors in wait_for_connect > - pass ConnectState as a parameter to allow concurrent connect ops > > getaddrinfo can g

[Qemu-devel] [PATCH v3 0/3] nonblocking connect address handling cleanup

2012-09-13 Thread Orit Wasserman
Changes from v2: - remove the use of getnameinfo - remove errp for inet_connect_addr - remove QemuOpt "block" - fix errors in wait_for_connect - pass ConnectState as a parameter to allow concurrent connect ops getaddrinfo can give us a list of addresses, bu