Re: [Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model

2019-08-14 Thread Cédric Le Goater
On 30/07/2019 07:44, Rashmica Gupta wrote: > There are a couple of things I'm not confident about here: > - what should be in init vs realize? > - should the irq state be in vmstate? > - is there a better way to do composition of classes (patch 3)? You can not do twice : obj = object_new(TY

Re: [Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model

2019-08-06 Thread Peter Maydell
On Tue, 30 Jul 2019 at 06:45, Rashmica Gupta wrote: > > There are a couple of things I'm not confident about here: > - what should be in init vs realize? We are not very good at documenting this distinction (and there's some bits of it I'm not sure about either), but: * init cannot contain anyth

[Qemu-devel] [PATCH v3 0/3] Add Aspeed GPIO controller model

2019-07-29 Thread Rashmica Gupta
There are a couple of things I'm not confident about here: - what should be in init vs realize? - should the irq state be in vmstate? - is there a better way to do composition of classes (patch 3)? v3: - didn't have each gpio set up as an irq - now can't access set AC on ast2400 (only exists on a