Re: [Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-14 Thread Fam Zheng
On Wed, 05/14 16:23, Kevin Wolf wrote: > Am 08.05.2014 um 07:57 hat Fam Zheng geschrieben: > > This drops the unnecessary bdrv_truncate() from, and also improves, > > cluster allocation code path. > > [...] > > > > Tested that this passes qemu-iotests for all VMDK subformats. > > > > Signed-off-b

Re: [Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-14 Thread Kevin Wolf
Am 08.05.2014 um 07:57 hat Fam Zheng geschrieben: > This drops the unnecessary bdrv_truncate() from, and also improves, > cluster allocation code path. > [...] > > Tested that this passes qemu-iotests for all VMDK subformats. > > Signed-off-by: Fam Zheng Unfortunately, this is seriously broken

[Qemu-devel] [PATCH v3] vmdk: Optimize cluster allocation

2014-05-07 Thread Fam Zheng
This drops the unnecessary bdrv_truncate() from, and also improves, cluster allocation code path. Before, when we need a new cluster, get_cluster_offset truncates the image to bdrv_getlength() + cluster_size, and returns the offset of added area, i.e. the image length before truncating. This is n