Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode

2018-09-16 Thread Maciej W. Rozycki
Hi Fredrik, > Many thanks for your review, Maciej, You are welcome! > > Eventually you'll have to remove all these instructions (plus LL and SC) > > from the system emulation mode. In fact I think it would make sense to do > > that right away, because I believe it will be a reasonably simpl

Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode

2018-09-16 Thread Fredrik Noring
Many thanks for your review, Maciej, > I have been more thorough on this occasion, and I do hope I have caught > everything. See the notes below, in addition to what the others wrote. > > Please apply to v3 accordingly; I started writing this before you sent > that version. Sure, next ver

Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode

2018-09-11 Thread Aleksandar Markovic
> > - organize the changes in the form of patch series > > What kind of granularity do you have in mind? The patch is quite small with > 79 insertions and 1 deletion in total. For patch organization, you may find these links useful: https://wiki.qemu.org/Contribute/SubmitAPatch and https://wi

Re: [Qemu-devel] [PATCH v3] target/mips: Support R5900 GCC programs in user mode

2018-09-08 Thread Fredrik Noring
Hi Aleksandar, > Please: > > - rebase your changes to the latest QEMU code Sure. V2 applied to 3.0.0 and this v3 applies to HEAD (commit 19b599f7664b). > - organize the changes in the form of patch series What kind of granularity do you have in mind? The patch is quite small with 79 insertions