Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-26 Thread Andreas Färber
Hi Mark, Am 26.03.2014 16:03, schrieb Mark Cave-Ayland: > On 24/03/14 22:43, Andreas Färber wrote: >> Am 24.03.2014 22:36, schrieb Peter Maydell: Peter - given that this prevents a guest from crashing the QEMU host, is it a candidate for 2.0? >>> >>> Yes, I think so -- it's small an

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-26 Thread Mark Cave-Ayland
On 24/03/14 22:43, Andreas Färber wrote: Am 24.03.2014 22:36, schrieb Peter Maydell: On 24 March 2014 21:07, Mark Cave-Ayland wrote: This patch fixes the original bug report, and doesn't appear to have any ill-effects on my SPARC32/SPARC64 image collection boot tests so: Tested-by: Mark Cave

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-24 Thread Andreas Färber
Am 24.03.2014 22:36, schrieb Peter Maydell: > On 24 March 2014 21:07, Mark Cave-Ayland > wrote: >> This patch fixes the original bug report, and doesn't appear to have any >> ill-effects on my SPARC32/SPARC64 image collection boot tests so: >> >> Tested-by: Mark Cave-Ayland >> >> Peter - given t

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-24 Thread Peter Maydell
On 24 March 2014 21:07, Mark Cave-Ayland wrote: > This patch fixes the original bug report, and doesn't appear to have any > ill-effects on my SPARC32/SPARC64 image collection boot tests so: > > Tested-by: Mark Cave-Ayland > > Peter - given that this prevents a guest from crashing the QEMU host,

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-24 Thread Mark Cave-Ayland
On 21/03/14 01:25, Olivier Danet wrote: The signed integer division -0x8000___ / -1 must be handled separately to avoid an overflow on the QEMU host. Negative overflow must be a negative number for correct sign extension in Sparc64 mode. Use constants. Signed-off-by: Olivier Danet

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-21 Thread Richard Henderson
On 03/21/2014 12:07 AM, Mark Cave-Ayland wrote: > > This basic patch looks good to me. My only comment is that I suspect for > bisection purposes it may be better to split this into 2 patches - one to > perform the conversion of all existing constants to INT*_MAX and INT*_MIN, and > then a second

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-21 Thread Richard Henderson
On 03/20/2014 06:25 PM, Olivier Danet wrote: > The signed integer division -0x8000___ / -1 must be handled > separately to avoid an overflow on the QEMU host. > > Negative overflow must be a negative number for correct sign > extension in Sparc64 mode. Use constants. > > Signed-off-b

Re: [Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-21 Thread Mark Cave-Ayland
On 21/03/14 01:25, Olivier Danet wrote: The signed integer division -0x8000___ / -1 must be handled separately to avoid an overflow on the QEMU host. Negative overflow must be a negative number for correct sign extension in Sparc64 mode. Use constants. Signed-off-by: Olivier Danet

[Qemu-devel] [PATCH v3] sparc : 32bits integer division overflow

2014-03-20 Thread Olivier Danet
The signed integer division -0x8000___ / -1 must be handled separately to avoid an overflow on the QEMU host. Negative overflow must be a negative number for correct sign extension in Sparc64 mode. Use constants. Signed-off-by: Olivier Danet --- target-sparc/helper.c | 17 +