Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
在 2018/5/30 下午6:54, Eduardo Otubo 写道: Can you send a v4 with a cleaned up version? Also fixing a typo on the text (elevateDprivileges). Why elevateDprivileges? The option name in the code is 'elevateprivileges'.

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Yi Min Zhao
在 2018/5/30 下午6:54, Eduardo Otubo 写道: On 29/05/2018 - 18:05:25, Yi Min Zhao wrote: 在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding ca

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-30 Thread Eduardo Otubo
On 29/05/2018 - 18:05:25, Yi Min Zhao wrote: > > > 在 2018/5/29 下午5:37, Paolo Bonzini 写道: > > On 29/05/2018 09:31, Yi Min Zhao wrote: > > > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > > > compiled. This would make libvirt set the corresponding capability and > > > then

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 11:53, Yi Min Zhao wrote: >>> >>> Yi Min >>> >> Acked-by: Eduardo Otubo >> >> > Thanks! I have included Paolo's squashing code. I'm not sure what I > should do next, sending a new version? No need, thanks! Paolo

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code rega

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:39, Eduardo Otubo 写道: On 29/05/2018 - 15:31:40, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午5:37, Paolo Bonzini 写道: On 29/05/2018 09:31, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code rega

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Eduardo Otubo
On 29/05/2018 - 15:31:40, Yi Min Zhao wrote: > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > compiled. This would make libvirt set the corresponding capability and > then trigger failure during guest startup. This patch moves the code > regarding seccomp command line opti

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Paolo Bonzini
On 29/05/2018 09:31, Yi Min Zhao wrote: > If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains > compiled. This would make libvirt set the corresponding capability and > then trigger failure during guest startup. This patch moves the code > regarding seccomp command line options t

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
在 2018/5/29 下午4:40, Ján Tomko 写道: On Tue, May 29, 2018 at 03:31:40PM +0800, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch mo

Re: [Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Ján Tomko
On Tue, May 29, 2018 at 03:31:40PM +0800, Yi Min Zhao wrote: If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code regarding seccomp command

[Qemu-devel] [PATCH v3] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

2018-05-29 Thread Yi Min Zhao
If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains compiled. This would make libvirt set the corresponding capability and then trigger failure during guest startup. This patch moves the code regarding seccomp command line options to qemu-seccomp.c file and wraps qemu_opts_foreac