Re: [Qemu-devel] [PATCH v3] qga: Support enum names in guest-file-seek

2020-03-20 Thread Eric Blake
On 3/20/20 8:49 AM, Peter Maydell wrote: On Tue, 9 Feb 2016 at 21:27, Eric Blake wrote: Magic constants are a pain to use, especially when we run the risk that our choice of '1' for QGA_SEEK_CUR might differ from the host or guest's choice of SEEK_CUR. Better is to use an enum value, via a qa

Re: [Qemu-devel] [PATCH v3] qga: Support enum names in guest-file-seek

2020-03-20 Thread Peter Maydell
On Tue, 9 Feb 2016 at 21:27, Eric Blake wrote: > > Magic constants are a pain to use, especially when we run the > risk that our choice of '1' for QGA_SEEK_CUR might differ from > the host or guest's choice of SEEK_CUR. Better is to use an > enum value, via a qapi alternate type for back-compatib

Re: [Qemu-devel] [PATCH v3] qga: Support enum names in guest-file-seek

2016-02-24 Thread Michael Roth
Quoting Eric Blake (2016-02-09 15:27:16) > Magic constants are a pain to use, especially when we run the > risk that our choice of '1' for QGA_SEEK_CUR might differ from > the host or guest's choice of SEEK_CUR. Better is to use an > enum value, via a qapi alternate type for back-compatibility. >

Re: [Qemu-devel] [PATCH v3] qga: Support enum names in guest-file-seek

2016-02-09 Thread Michael Roth
Quoting Eric Blake (2016-02-09 15:27:16) > Magic constants are a pain to use, especially when we run the > risk that our choice of '1' for QGA_SEEK_CUR might differ from > the host or guest's choice of SEEK_CUR. Better is to use an > enum value, via a qapi alternate type for back-compatibility. >

[Qemu-devel] [PATCH v3] qga: Support enum names in guest-file-seek

2016-02-09 Thread Eric Blake
Magic constants are a pain to use, especially when we run the risk that our choice of '1' for QGA_SEEK_CUR might differ from the host or guest's choice of SEEK_CUR. Better is to use an enum value, via a qapi alternate type for back-compatibility. With this, {"command":"guest-file-seek", "argumen