Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 18:39:07 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Wed, 15 Dec 2010 11:49:23 +0100 > > Markus Armbruster wrote: > > > >> Lai Jiangshan writes: > >> > >> > Convert do_inject_nmi() to QObject, QError, we need to use it(via > >> > libvirt). > >> > >

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Dec 2010 11:49:23 +0100 > Markus Armbruster wrote: > >> Lai Jiangshan writes: >> >> > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). >> > >> > changed from v1 >> > Add document. >> > Add error handling when the cpu index is inva

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Luiz Capitulino
On Wed, 15 Dec 2010 11:49:23 +0100 Markus Armbruster wrote: > Lai Jiangshan writes: > > > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > > > changed from v1 > > Add document. > > Add error handling when the cpu index is invalid. > > > > changed from v2 > > use Q

Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Markus Armbruster
Lai Jiangshan writes: > Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). > > changed from v1 > Add document. > Add error handling when the cpu index is invalid. > > changed from v2 > use QERR_INVALID_PARAMETER_VALUE as Markus suggest. > > Signed-off-by: Lai Jiangshan

[Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-15 Thread Lai Jiangshan
Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). changed from v1 Add document. Add error handling when the cpu index is invalid. changed from v2 use QERR_INVALID_PARAMETER_VALUE as Markus suggest. Signed-off-by: Lai Jiangshan --- diff --git a/hmp-commands.hx b/hmp-c