Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-03 Thread Andrea Bolognani
On Thu, 2017-02-02 at 23:07 +0100, Gerd Hoffmann wrote: > > Oh, wait, I realize where the mismatch comes from now: > > on real hardware (my laptop) the video card is plugged > > into 00:02.0, but the default one you get when you don't > > pass -nodefault to QEMU is plugged into 00:01.0! >  > And th

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Gerd Hoffmann
On Do, 2017-02-02 at 16:35 +0100, Andrea Bolognani wrote: > On Thu, 2017-02-02 at 15:55 +0100, Gerd Hoffmann wrote: > > > +++ b/docs/q35-emulated.cfg > > > > > > +# 00:01.0 VGA compatible controller > > > > > > +[device "video"] > > > + driver = "VGA" > > > + bus = "pcie.0" > > > + addr = "0

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Andrea Bolognani
On Thu, 2017-02-02 at 15:55 +0100, Gerd Hoffmann wrote: > > +++ b/docs/q35-emulated.cfg > >  > > +#   00:01.0 VGA compatible controller > >  > > +[device "video"] > > +  driver = "VGA" > > +  bus = "pcie.0" > > +  addr = "02.0" >  > Here is a address mismatch ;) >  > Otherwise looks all fine to me.

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Andrea Bolognani
On Thu, 2017-02-02 at 15:55 +0100, Gerd Hoffmann wrote: > > +++ b/docs/q35-emulated.cfg > >  > > +#   00:01.0 VGA compatible controller > >  > > +[device "video"] > > +  driver = "VGA" > > +  bus = "pcie.0" > > +  addr = "02.0" >  > Here is a address mismatch ;) Oh, wait, I realize where the misma

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Gerd Hoffmann
Hi, > +++ b/docs/q35-emulated.cfg > +# 00:01.0 VGA compatible controller > +[device "video"] > + driver = "VGA" > + bus = "pcie.0" > + addr = "02.0" Here is a address mismatch ;) Otherwise looks all fine to me. cheers, Gerd

[Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Andrea Bolognani
Instead of having a single sample configuration file, we now have several: * q35-emulated.cfg documents the default devices QEMU adds to a q35 guest and the additional devices that are pretty much guaranteed to be present in a physical q35-based machine; * q35-virtio-graphical.cfg