Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-14 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 08:54:36PM +0800, Cao jin wrote: > When user specify invalid property aer_log_max, device should fail to > create, and report appropriate message. > > Signed-off-by: Cao jin > Reviewed-by: Marcel Apfelbaum I'll review and merge after release. Pls ping me then. > --- >

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-13 Thread Cao jin
On 11/12/2016 01:37 AM, Michael S. Tsirkin wrote: On Thu, Nov 03, 2016 at 08:57:56PM +0800, Cao jin wrote: When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin Was this tested outside of make check? Yes, I j

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-11 Thread Michael S. Tsirkin
On Thu, Nov 03, 2016 at 08:57:56PM +0800, Cao jin wrote: > When user specify invalid property aer_log_max, device should fail to > create, and report appropriate message. > > Signed-off-by: Cao jin Was this tested outside of make check? > --- > v3 changelog: > 1. get rid of PCIE_AER_LOG_MAX_UNS

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-03 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman > On 3 Nov 2016, at 14:57 PM, Cao jin wrote: > > When user specify invalid property aer_log_max, device should fail to > create, and report appropriate message. > > Signed-off-by: Cao jin > --- > v3 changelog: > 1. get rid of PCIE_AER_LOG_MAX_UNSET > > Sorry I forge

Re: [Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-03 Thread Marcel Apfelbaum
On 11/03/2016 02:57 PM, Cao jin wrote: When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin --- v3 changelog: 1. get rid of PCIE_AER_LOG_MAX_UNSET Sorry I forget to commit the amendment again... hw/net/e1000e.c

[Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-03 Thread Cao jin
When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin --- v3 changelog: 1. get rid of PCIE_AER_LOG_MAX_UNSET Sorry I forget to commit the amendment again... hw/net/e1000e.c| 2 +- hw/pci-bridge/

[Qemu-devel] [PATCH v3] pcie_aer: Convert pcie_aer_init to Error

2016-11-03 Thread Cao jin
When user specify invalid property aer_log_max, device should fail to create, and report appropriate message. Signed-off-by: Cao jin Reviewed-by: Marcel Apfelbaum --- v3 changelog: 1. get rid of PCIE_AER_LOG_MAX_UNSET hw/net/e1000e.c| 2 +- hw/pci-bridge/ioh3420.c