Re: [Qemu-devel] [PATCH v3] pci: fix pci_requester_id()

2016-05-17 Thread Peter Xu
On Tue, May 17, 2016 at 10:46:12AM +0300, Michael S. Tsirkin wrote: > On Tue, May 17, 2016 at 02:45:07PM +0800, Peter Xu wrote: > > This fix SID verification failure when IOMMU IR is enabled with PCI > > bridges. Existing pci_requester_id() is more like getting BDF info > > only. Renaming it to pci

Re: [Qemu-devel] [PATCH v3] pci: fix pci_requester_id()

2016-05-17 Thread Michael S. Tsirkin
On Tue, May 17, 2016 at 02:45:07PM +0800, Peter Xu wrote: > This fix SID verification failure when IOMMU IR is enabled with PCI > bridges. Existing pci_requester_id() is more like getting BDF info > only. Renaming it to pci_get_bdf(). Meanwhile, we provide the correct > implementation to get reques

[Qemu-devel] [PATCH v3] pci: fix pci_requester_id()

2016-05-16 Thread Peter Xu
This fix SID verification failure when IOMMU IR is enabled with PCI bridges. Existing pci_requester_id() is more like getting BDF info only. Renaming it to pci_get_bdf(). Meanwhile, we provide the correct implementation to get requester ID. VT-d spec 5.1.1 is a good reference to go, though it talks