Re: [Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-17 Thread Mao Zhongyi
Hi, Markus On 05/17/2017 03:04 PM, Markus Armbruster wrote: Mao Zhongyi writes: On 05/16/2017 11:29 PM, Markus Armbruster wrote: Mao Zhongyi writes: The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .real

Re: [Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-17 Thread Markus Armbruster
Mao Zhongyi writes: > Hi, Markus > > On 05/16/2017 11:29 PM, Markus Armbruster wrote: >> Mao Zhongyi writes: >> >>> The rocker device still implements the old PCIDeviceClass .init() >>> instead of the new .realize(). All devices need to be converted to >>> .realize(). >> >> Thanks for chipping i

Re: [Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-16 Thread Mao Zhongyi
Hi, Markus On 05/16/2017 11:29 PM, Markus Armbruster wrote: Mao Zhongyi writes: The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). Thanks for chipping in! .init() reports errors with fprintf() an

Re: [Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-16 Thread Markus Armbruster
Mao Zhongyi writes: > The rocker device still implements the old PCIDeviceClass .init() > instead of the new .realize(). All devices need to be converted to > .realize(). Thanks for chipping in! > .init() reports errors with fprintf() and return 0 on success, negative > number on failure. Meanw

[Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-16 Thread Mao Zhongyi
The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a specif