Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-24 Thread Markus Armbruster
Peter Xu writes: > On Thu, May 24, 2018 at 10:22:48AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Wed, May 23, 2018 at 03:13:07PM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: >> >> >>

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-24 Thread Peter Xu
On Thu, May 24, 2018 at 10:22:48AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, May 23, 2018 at 03:13:07PM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: > >> >> Peter Xu writes: > >> >>

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-24 Thread Markus Armbruster
Peter Xu writes: > On Wed, May 23, 2018 at 03:13:07PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > In the future the monitor iothread may be accessing the cur_mon as >> >> >

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 03:13:07PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > In the future the monitor iothread may be accessing the cur_mon as > >> > well (via monitor_qmp_dispat

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > In the future the monitor iothread may be accessing the cur_mon as >> > well (via monitor_qmp_dispatch_one()). Before we introduce a real >> > Out-Of-Band command, >> >> Uh, inhow

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-23 Thread Peter Xu
On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > In the future the monitor iothread may be accessing the cur_mon as > > well (via monitor_qmp_dispatch_one()). Before we introduce a real > > Out-Of-Band command, > > Uh, inhowfar are the commands marked

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-23 Thread Markus Armbruster
Peter Xu writes: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, Uh, inhowfar are the commands marked allow-oob: true now not real? These are migrate-recover, migrate-pause, x-oob-tes

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-05-21 Thread Peter Xu
On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, let's convert the cur_mon variable to be a > per-thread variable to make sure th

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-18 Thread Peter Xu
On Wed, Apr 18, 2018 at 09:45:27AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, Apr 18, 2018 at 01:12:24PM +0800, Stefan Hajnoczi wrote: > >> On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: > >> > Stefan Hajnoczi writes: > >> > > >> > > On Mon, Apr 16, 201

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-18 Thread Markus Armbruster
Peter Xu writes: > On Wed, Apr 18, 2018 at 01:12:24PM +0800, Stefan Hajnoczi wrote: >> On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: >> > Stefan Hajnoczi writes: >> > >> > > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: >> > >> On Mon, Apr 16, 2018 at 04:37:48PM

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-17 Thread Peter Xu
On Wed, Apr 18, 2018 at 01:12:24PM +0800, Stefan Hajnoczi wrote: > On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > > > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: > > >> On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wr

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-17 Thread Stefan Hajnoczi
On Tue, Apr 17, 2018 at 11:05:47AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: > >> On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > >> > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > >>

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-17 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: >> On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: >> > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: >> > > In the future the monitor iothread may be accessing the cur_mon as >> > > w

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-17 Thread Stefan Hajnoczi
On Mon, Apr 16, 2018 at 05:17:32PM +0800, Peter Xu wrote: > On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > > > In the future the monitor iothread may be accessing the cur_mon as > > > well (via monitor_qmp_dispatch_on

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-16 Thread Peter Xu
On Mon, Apr 16, 2018 at 04:37:48PM +0800, Stefan Hajnoczi wrote: > On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > > In the future the monitor iothread may be accessing the cur_mon as > > well (via monitor_qmp_dispatch_one()). Before we introduce a real > > Out-Of-Band command, let's c

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-16 Thread Stefan Hajnoczi
On Thu, Apr 12, 2018 at 02:11:08PM +0800, Peter Xu wrote: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, let's convert the cur_mon variable to be a > per-thread variable to make sure th

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-13 Thread Marc-André Lureau
On Thu, Apr 12, 2018 at 8:11 AM, Peter Xu wrote: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, let's convert the cur_mon variable to be a > per-thread variable to make sure there won'

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-12 Thread Eric Blake
On 04/12/2018 01:11 AM, Peter Xu wrote: > In the future the monitor iothread may be accessing the cur_mon as > well (via monitor_qmp_dispatch_one()). Before we introduce a real > Out-Of-Band command, let's convert the cur_mon variable to be a > per-thread variable to make sure there won't be a rac

[Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

2018-04-11 Thread Peter Xu
In the future the monitor iothread may be accessing the cur_mon as well (via monitor_qmp_dispatch_one()). Before we introduce a real Out-Of-Band command, let's convert the cur_mon variable to be a per-thread variable to make sure there won't be a race between threads. Note that thread variables a