Re: [Qemu-devel] [PATCH v3] linux-user: remove useless padding in flock64 structure

2018-05-02 Thread Richard Henderson
On 05/02/2018 11:25 AM, Laurent Vivier wrote: > --- a/linux-user/arm/target_structs.h > +++ b/linux-user/arm/target_structs.h > @@ -49,4 +49,13 @@ struct target_shmid_ds { > abi_ulong __unused5; > }; > > +#if defined(TARGET_ABI32) > +struct target_oabi_flock64 { Isn't ABI32 implied by the

[Qemu-devel] [PATCH v3] linux-user: remove useless padding in flock64 structure

2018-05-02 Thread Laurent Vivier
Since commit 8efb2ed5ec ("linux-user: Correct signedness of target_flock l_start and l_len fields"), flock64 structure uses abi_llong for l_start and l_len in place of "unsigned long long" this should force them to be aligned accordingly to the target rules. So we can remove the padding field and t