Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Peter Maydell
On 18 October 2013 14:19, Alex Bennée wrote: > > peter.mayd...@linaro.org writes: >> Oh, and this belongs in hw/misc/, since it's a standalone >> device model. > Ahh I was pondering this. Surely as it's only associated with ARM (and > specifically integrator) it gets grouped with that? No, the o

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 18 October 2013 12:45, wrote: >> From: Alex Bennée >> >> Commit 9b8c69243 (since reverted) broke the ability to boot the kernel >> as the value returned by unassigned_mem_read returned non-zero and left >> the kernel looping forever waiting for it to chang

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Peter Maydell
On 18 October 2013 12:45, wrote: > From: Alex Bennée > > Commit 9b8c69243 (since reverted) broke the ability to boot the kernel > as the value returned by unassigned_mem_read returned non-zero and left > the kernel looping forever waiting for it to change (see > integrator_led_set in the kernel

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 18 October 2013 12:45, wrote: >> +typedef struct { >> +SysBusDevice parent_obj; >> + >> +MemoryRegion iomem; >> + >> +uint32_t alpha; >> +uint32_t leds; >> +uint32_t switches; > > These three fields are never used, or did I miss somethin

Re: [Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread Peter Maydell
On 18 October 2013 12:45, wrote: > +typedef struct { > +SysBusDevice parent_obj; > + > +MemoryRegion iomem; > + > +uint32_t alpha; > +uint32_t leds; > +uint32_t switches; These three fields are never used, or did I miss something? > +} IntegratorDebugState; Looks good other

[Qemu-devel] [PATCH v3] integrator: fix Linux boot failure by emulating dbg region

2013-10-18 Thread alex . bennee
From: Alex Bennée Commit 9b8c69243 (since reverted) broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in the kernel code). Relying on a varying implementation de