Re: [Qemu-devel] [PATCH v3] hw: fix error reporting for missing option ROMs

2016-04-04 Thread Eduardo Habkost
Hi, Sorry for the long delay in reviewing this. On Fri, Mar 11, 2016 at 05:14:22PM +, Daniel P. Berrange wrote: > If QEMU fails to load any of the VGA ROMs, it prints a message > to stderr and then carries on as if everything was fine, despite > the VGA interface not being functional. This ex

[Qemu-devel] [PATCH v3] hw: fix error reporting for missing option ROMs

2016-03-11 Thread Daniel P. Berrange
If QEMU fails to load any of the VGA ROMs, it prints a message to stderr and then carries on as if everything was fine, despite the VGA interface not being functional. This extends the the various rom_add_*() methods in loader.h to accept a 'Error **errp' parameter. The VGA device realizefn() impls