Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Alex Bennée writes: >> >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to read the initial flash content

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> It looks like there was going to be code to check we had some sort of >> alignment so lets replace it with an actual check. This is a bit more >> useful than the enigmatic "failed to read the initial flash content" >> when we attempt to read

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Markus Armbruster
Alex Bennée writes: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the number of bytes the device shoul

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Philippe Mathieu-Daudé
On 2/22/19 9:09 AM, Laszlo Ersek wrote: > On 02/21/19 21:07, Alex Bennée wrote: >> Laszlo Ersek writes: >> >>> On 02/21/19 19:48, Alex Bennée wrote: It looks like there was going to be code to check we had some sort of alignment so lets replace it with an actual check. This is a bit more

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Laszlo Ersek
On 02/21/19 21:07, Alex Bennée wrote: > > Laszlo Ersek writes: > >> On 02/21/19 19:48, Alex Bennée wrote: >>> It looks like there was going to be code to check we had some sort of >>> alignment so lets replace it with an actual check. This is a bit more >>> useful than the enigmatic "failed to r

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-22 Thread Laszlo Ersek
On 02/21/19 21:42, Philippe Mathieu-Daudé wrote: > Hi Alex, > > On 2/21/19 7:48 PM, Alex Bennée wrote: >> It looks like there was going to be code to check we had some sort of >> alignment so lets replace it with an actual check. This is a bit more >> useful than the enigmatic "failed to read the

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Philippe Mathieu-Daudé
Hi Alex, On 2/21/19 7:48 PM, Alex Bennée wrote: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the numbe

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Alex Bennée
Laszlo Ersek writes: > On 02/21/19 19:48, Alex Bennée wrote: >> It looks like there was going to be code to check we had some sort of >> alignment so lets replace it with an actual check. This is a bit more >> useful than the enigmatic "failed to read the initial flash content" >> when we attem

Re: [Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Laszlo Ersek
On 02/21/19 19:48, Alex Bennée wrote: > It looks like there was going to be code to check we had some sort of > alignment so lets replace it with an actual check. This is a bit more > useful than the enigmatic "failed to read the initial flash content" > when we attempt to read the number of bytes

[Qemu-devel] [PATCH v3] hw/block: better reporting on pflash backing file mismatch

2019-02-21 Thread Alex Bennée
It looks like there was going to be code to check we had some sort of alignment so lets replace it with an actual check. This is a bit more useful than the enigmatic "failed to read the initial flash content" when we attempt to read the number of bytes the device should have. This is a potential c