Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 08:37:14 +0800 Wei Yang wrote: > On Tue, Mar 19, 2019 at 10:00:38AM +0100, Igor Mammedov wrote: > >On Tue, 19 Mar 2019 08:45:23 +0800 > >Wei Yang wrote: > > > >> On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: > >> >On Fri, 15 Mar 2019 08:44:32 +0800 > >> >

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-19 Thread Wei Yang
On Tue, Mar 19, 2019 at 10:00:38AM +0100, Igor Mammedov wrote: >On Tue, 19 Mar 2019 08:45:23 +0800 >Wei Yang wrote: > >> On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: >> >On Fri, 15 Mar 2019 08:44:32 +0800 >> >Wei Yang wrote: >> > >> >in subject: s/extract/generalize/ >> > >> >

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-19 Thread Igor Mammedov
On Tue, 19 Mar 2019 08:45:23 +0800 Wei Yang wrote: > On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: > >On Fri, 15 Mar 2019 08:44:32 +0800 > >Wei Yang wrote: > > > >in subject: s/extract/generalize/ > > > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-18 Thread Wei Yang
On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: >On Fri, 15 Mar 2019 08:44:32 +0800 >Wei Yang wrote: > >in subject: s/extract/generalize/ > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch extract

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-18 Thread Wei Yang
On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: >On Fri, 15 Mar 2019 08:44:32 +0800 >Wei Yang wrote: > >in subject: s/extract/generalize/ > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch extract

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-18 Thread Igor Mammedov
On Fri, 15 Mar 2019 08:44:32 +0800 Wei Yang wrote: in subject: s/extract/generalize/ > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch extract acpi_add_rom_blob() to utils.c by passing s/extract/moves/

[Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-14 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch extract acpi_add_rom_blob() to utils.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang --- v3: * put acpi_add_rom_blob() to hw/acpi/utils.c v2: * remove unused h