Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-07 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:14:48PM +, Stefano Stabellini wrote: > On Sat, 2 Jan 2016, Michael S. Tsirkin wrote: > > On Sat, Jan 02, 2016 at 04:02:20PM +0800, Cao jin wrote: > > > Fix the bug introduced by 595a4f07: function host_pci_config_read() > > > should be > > > pass-by-reference, not va

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-04 Thread Stefano Stabellini
On Sat, 2 Jan 2016, Michael S. Tsirkin wrote: > On Sat, Jan 02, 2016 at 04:02:20PM +0800, Cao jin wrote: > > Fix the bug introduced by 595a4f07: function host_pci_config_read() should > > be > > pass-by-reference, not value. > > > > Signed-off-by: Cao jin > > --- > > v3 changelog: > > 1. Remove

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Michael S. Tsirkin
On Sat, Jan 02, 2016 at 04:02:20PM +0800, Cao jin wrote: > Fix the bug introduced by 595a4f07: function host_pci_config_read() should be > pass-by-reference, not value. > > Signed-off-by: Cao jin > --- > v3 changelog: > 1. Remove cpu_to_le32() since the code only runs on X86. It really should be

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Michael S. Tsirkin
On Sat, Jan 02, 2016 at 10:06:10AM +0100, Stefan Weil wrote: > Am 02.01.2016 um 09:02 schrieb Cao jin: > > Fix the bug introduced by 595a4f07: function host_pci_config_read() should > > be > > pass-by-reference, not value. > > > > Signed-off-by: Cao jin > > --- > > v3 changelog: > > 1. Remove cpu

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Paolo Bonzini
On 02/01/2016 10:06, Stefan Weil wrote: > Am 02.01.2016 um 09:02 schrieb Cao jin: >> Fix the bug introduced by 595a4f07: function host_pci_config_read() should be >> pass-by-reference, not value. >> >> Signed-off-by: Cao jin >> --- >> v3 changelog: >> 1. Remove cpu_to_le32() since the code only

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Cao jin
Hi, Happy new year:) On 01/02/2016 05:06 PM, Stefan Weil wrote: Am 02.01.2016 um 09:02 schrieb Cao jin: Fix the bug introduced by 595a4f07: function host_pci_config_read() should be pass-by-reference, not value. Signed-off-by: Cao jin --- v3 changelog: 1. Remove cpu_to_le32() since the co

Re: [Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Stefan Weil
Am 02.01.2016 um 09:02 schrieb Cao jin: > Fix the bug introduced by 595a4f07: function host_pci_config_read() should be > pass-by-reference, not value. > > Signed-off-by: Cao jin > --- > v3 changelog: > 1. Remove cpu_to_le32() since the code only runs on X86. > > hw/pci-host/piix.c | 8 +--- >

[Qemu-devel] [PATCH v3] bugfix: passing reference instead of value

2016-01-02 Thread Cao jin
Fix the bug introduced by 595a4f07: function host_pci_config_read() should be pass-by-reference, not value. Signed-off-by: Cao jin --- v3 changelog: 1. Remove cpu_to_le32() since the code only runs on X86. hw/pci-host/piix.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --