Re: [Qemu-devel] [PATCH v3] block: fix QEMU crash with scsi-hd and drive_del

2018-05-28 Thread Greg Kurz
On Fri, 25 May 2018 16:02:46 +0200 Kevin Wolf wrote: > Am 25.05.2018 um 13:53 hat Greg Kurz geschrieben: > > On Fri, 25 May 2018 10:37:15 +0200 > > Kevin Wolf wrote: > > > > > Am 25.05.2018 um 00:53 hat Greg Kurz geschrieben: > > > > Removing a drive with drive_del while it is being used to

Re: [Qemu-devel] [PATCH v3] block: fix QEMU crash with scsi-hd and drive_del

2018-05-25 Thread Kevin Wolf
Am 25.05.2018 um 13:53 hat Greg Kurz geschrieben: > On Fri, 25 May 2018 10:37:15 +0200 > Kevin Wolf wrote: > > > Am 25.05.2018 um 00:53 hat Greg Kurz geschrieben: > > > Removing a drive with drive_del while it is being used to run an I/O > > > intensive workload can cause QEMU to crash. > > > >

Re: [Qemu-devel] [PATCH v3] block: fix QEMU crash with scsi-hd and drive_del

2018-05-25 Thread Greg Kurz
On Fri, 25 May 2018 10:37:15 +0200 Kevin Wolf wrote: > Am 25.05.2018 um 00:53 hat Greg Kurz geschrieben: > > Removing a drive with drive_del while it is being used to run an I/O > > intensive workload can cause QEMU to crash. > > > > An AIO flush can yield at some point: > > > > blk_aio_flush_e

Re: [Qemu-devel] [PATCH v3] block: fix QEMU crash with scsi-hd and drive_del

2018-05-25 Thread Kevin Wolf
Am 25.05.2018 um 00:53 hat Greg Kurz geschrieben: > Removing a drive with drive_del while it is being used to run an I/O > intensive workload can cause QEMU to crash. > > An AIO flush can yield at some point: > > blk_aio_flush_entry() > blk_co_flush(blk) > bdrv_co_flush(blk->root->bs) >...

[Qemu-devel] [PATCH v3] block: fix QEMU crash with scsi-hd and drive_del

2018-05-24 Thread Greg Kurz
Removing a drive with drive_del while it is being used to run an I/O intensive workload can cause QEMU to crash. An AIO flush can yield at some point: blk_aio_flush_entry() blk_co_flush(blk) bdrv_co_flush(blk->root->bs) ... qemu_coroutine_yield() and let the HMP command to run, free bl