Re: [Qemu-devel] [PATCH v3] block: always compile-check debug prints

2016-04-28 Thread Eric Blake
On 04/28/2016 09:00 PM, Zhou Jie wrote: > Files with conditional debug statements should ensure that the printf is > always compiled. > This prevents bitrot of the format string of the debug statement. Still missing a sentence about the intentional change to use stderr. > > Signed-off-by: Zhou J

[Qemu-devel] [PATCH v3] block: always compile-check debug prints

2016-04-28 Thread Zhou Jie
Files with conditional debug statements should ensure that the printf is always compiled. This prevents bitrot of the format string of the debug statement. Signed-off-by: Zhou Jie Reviewed-by: Eric Blake --- v1 -> v2: * Keep the user-visible witness as defined/undefined, and create a seconda