Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Andreas Färber
Am 06.07.2012 16:01, schrieb Peter Maydell: > On 6 July 2012 14:41, Andreas Färber wrote: >> Small improvement would be to replace "Returns the" with "Returns: The" >> in line with how you annotated the arguments, and the function summary >> should go into its own paragraph between @foo: and Retur

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Peter Maydell
On 6 July 2012 14:41, Andreas Färber wrote: > Small improvement would be to replace "Returns the" with "Returns: The" > in line with how you annotated the arguments, and the function summary > should go into its own paragraph between @foo: and Returns:. > > http://developer.gnome.org/gtk-doc-manua

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Andreas Färber
Am 28.06.2012 14:55, schrieb Peter Maydell: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. > > Suggested-by: Jia Liu > Suggested-by: Avi Kivity > Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Peter Maydell
On 28 June 2012 13:55, Peter Maydell wrote: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. NB: I'm planning to put this v3 into a target-arm pullreq at the end of next wee

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-06-28 Thread Eric Blake
On 06/28/2012 06:55 AM, Peter Maydell wrote: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. > > Suggested-by: Jia Liu > Suggested-by: Avi Kivity > Signed-off-by: Peter Ma

[Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-06-28 Thread Peter Maydell
Add functions deposit32(), deposit64(), extract32() and extract64() to extract and deposit bitfields in 32 and 64 bit words. Based on ideas by Jia Liu and Avi Kivity. Suggested-by: Jia Liu Suggested-by: Avi Kivity Signed-off-by: Peter Maydell --- Changes: v1->v2: added missing brackets v2->v3