Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Programmingkid
On Feb 21, 2015, at 7:14 AM, Peter Maydell wrote: > On 20 February 2015 at 05:51, Programmingkid > wrote: >> This patch sets the icon for the QEMU binary on Mac OS X. >> >> Signed-off-by: John Arbuckle >> >> --- >> Added conditional code to make the icon setting happen only on Mac OS X. >>

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Programmingkid
On Feb 20, 2015, at 8:05 PM, Peter Maydell wrote: > On 21 February 2015 at 02:25, Paolo Bonzini wrote: >> I honestly don't know which versions are supported. 10.5 was released >> in 2007 and it is enough for Darwin/PPC, so it's probably okay. > > Yes, I think 10.5 is the earliest we currently

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-21 Thread Peter Maydell
On 20 February 2015 at 05:51, Programmingkid wrote: > This patch sets the icon for the QEMU binary on Mac OS X. > > Signed-off-by: John Arbuckle > > --- > Added conditional code to make the icon setting happen only on Mac OS X. > > Makefile.target |4 + > pc-bios/qemu.rsrc | 1504 > ++

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Peter Maydell
On 21 February 2015 at 02:25, Paolo Bonzini wrote: > I honestly don't know which versions are supported. 10.5 was released > in 2007 and it is enough for Darwin/PPC, so it's probably okay. Yes, I think 10.5 is the earliest we currently claim to care about. (In practice I'm not sure when anybody

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 18:06, Programmingkid wrote: > I did some looking myself and found out that the Rez and SetFile command > are missing on Mac OS 10.4 (and probably below). They are available on > Mac OS 10.5 and Mac OS 10.6. Since this feature isn't important, I can > add conditional code that would

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 6:41 AM, Paolo Bonzini wrote: > > > On 19/02/2015 21:51, Programmingkid wrote: >> This patch sets the icon for the QEMU binary on Mac OS X. >> >> Signed-off-by: John Arbuckle >> >> --- >> Added conditional code to make the icon setting happen only on Mac OS X. > > Appli