On 03/30/2016 05:00 PM, Marcel Apfelbaum wrote:
On 03/30/2016 07:10 AM, Cao jin wrote:
Hi,
Yes, I should add more hint message. I don`t quite understand about:
/have a "warning only" error type so the reporting party can decide to
issue a warning or to fail/
Do you mean still using VM
On 03/30/2016 07:10 AM, Cao jin wrote:
Hi Marcel,
Thanks for your quick review for this big fat patch:)
please see my comments inline.
On 03/30/2016 04:56 AM, Marcel Apfelbaum wrote:
On 03/28/2016 01:44 PM, Cao jin wrote:
-#define VMXNET3_USE_64BIT (true)
-#define VMXNET3_PE
Hi Marcel,
Thanks for your quick review for this big fat patch:)
please see my comments inline.
On 03/30/2016 04:56 AM, Marcel Apfelbaum wrote:
On 03/28/2016 01:44 PM, Cao jin wrote:
-#define VMXNET3_USE_64BIT (true)
-#define VMXNET3_PER_VECTOR_MASK (false)
-
-static bool
-vm
On 03/28/2016 01:44 PM, Cao jin wrote:
Add param Error **errp, and change pci_add_capability() to
pci_add_capability2(), because pci_add_capability() report error, and
msi_init() is widely used in realize(), so it is not suitable for realize().
Hi,
The patch is looking good in my opinion, a fe
Add param Error **errp, and change pci_add_capability() to
pci_add_capability2(), because pci_add_capability() report error, and
msi_init() is widely used in realize(), so it is not suitable for realize().
Also fix all the callers who should deal with the msi_init() failure but
actually not. The a
