Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Marc Marí
> When I first tried to compile this (on fc23), I got: > > In file included from /usr/include/features.h:389:0, > from /usr/include/stdint.h:25, > from > /usr/lib/gcc/x86_64-redhat-linux/5.3.1/include/stdint.h:9, > from linuxboot_dma.c:62: > /us

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Kevin O'Connor
On Thu, Jan 28, 2016 at 12:20:33PM +0100, Marc Marí wrote: > A small cosmetic comment in this patch: is there any practical reason to > mix the three ways to put inline assembly (asm(), asm volatile() and > __asm__ __volatile__ ()) in this patch? No reason - it was just copy-and-paste crud. > >

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Marc Marí
On Wed, 27 Jan 2016 19:14:54 -0500 "Kevin O'Connor" wrote: > On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > > This optionrom is based on linuxboot.S. > > Hi Marc, > > Out of curiousity, how does the timing with this option rom compare to > the previous SeaBIOS patches that imple

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Stefan Hajnoczi
On Thu, Jan 28, 2016 at 11:18:07AM +0100, Marc Marí wrote: > On Wed, 27 Jan 2016 12:17:27 -0500 > "Kevin O'Connor" wrote: > > > On Wed, Jan 27, 2016 at 05:57:28PM +0100, Marc Marí wrote: > > > On Wed, 27 Jan 2016 16:43:29 + > > > Stefan Hajnoczi wrote: > > > > > > > On Tue, Jan 26, 2016 a

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-28 Thread Marc Marí
On Wed, 27 Jan 2016 12:17:27 -0500 "Kevin O'Connor" wrote: > On Wed, Jan 27, 2016 at 05:57:28PM +0100, Marc Marí wrote: > > On Wed, 27 Jan 2016 16:43:29 + > > Stefan Hajnoczi wrote: > > > > > On Tue, Jan 26, 2016 at 12:26:12PM +0100, Gerd Hoffmann wrote: > > > > On Di, 2016-01-26 at 12:

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-27 Thread Kevin O'Connor
On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > This optionrom is based on linuxboot.S. Hi Marc, Out of curiousity, how does the timing with this option rom compare to the previous SeaBIOS patches that implemented linux dma loading? When I first tried to compile this (on fc23), I g

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-27 Thread Kevin O'Connor
On Wed, Jan 27, 2016 at 05:57:28PM +0100, Marc Marí wrote: > On Wed, 27 Jan 2016 16:43:29 + > Stefan Hajnoczi wrote: > > > On Tue, Jan 26, 2016 at 12:26:12PM +0100, Gerd Hoffmann wrote: > > > On Di, 2016-01-26 at 12:20 +0100, Marc Marí wrote: > > > > On Tue, 26 Jan 2016 11:11:54 + > > >

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-27 Thread Marc Marí
On Wed, 27 Jan 2016 16:43:29 + Stefan Hajnoczi wrote: > On Tue, Jan 26, 2016 at 12:26:12PM +0100, Gerd Hoffmann wrote: > > On Di, 2016-01-26 at 12:20 +0100, Marc Marí wrote: > > > On Tue, 26 Jan 2016 11:11:54 + > > > Stefan Hajnoczi wrote: > > > > > > > On Mon, Jan 25, 2016 at 02:17

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-27 Thread Stefan Hajnoczi
On Tue, Jan 26, 2016 at 12:26:12PM +0100, Gerd Hoffmann wrote: > On Di, 2016-01-26 at 12:20 +0100, Marc Marí wrote: > > On Tue, 26 Jan 2016 11:11:54 + > > Stefan Hajnoczi wrote: > > > > > On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > > > > +linuxboot_dma.img: linuxboot_dma.o >

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-26 Thread Gerd Hoffmann
On Di, 2016-01-26 at 12:20 +0100, Marc Marí wrote: > On Tue, 26 Jan 2016 11:11:54 + > Stefan Hajnoczi wrote: > > > On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > > > +linuxboot_dma.img: linuxboot_dma.o > > > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 > > > -Ttext

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-26 Thread Marc Marí
On Tue, 26 Jan 2016 11:11:54 + Stefan Hajnoczi wrote: > On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > > +linuxboot_dma.img: linuxboot_dma.o > > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 > > -Ttext 0 -e _start -s -o $@ $<," Building $(TARGET_DIR)$@") + > > %.

Re: [Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-26 Thread Stefan Hajnoczi
On Mon, Jan 25, 2016 at 02:17:48PM +0100, Marc Marí wrote: > +linuxboot_dma.img: linuxboot_dma.o > + $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -m elf_i386 -Ttext 0 -e > _start -s -o $@ $<," Building $(TARGET_DIR)$@") > + > %.img: %.o > $(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Tte

[Qemu-devel] [PATCH v3] Add optionrom compatible with fw_cfg DMA version

2016-01-25 Thread Marc Marí
This optionrom is based on linuxboot.S. Signed-off-by: Marc Marí --- .gitignore| 4 + hw/i386/pc.c | 9 +- hw/nvram/fw_cfg.c | 2 +- include/hw/nvram/fw_cfg.h | 1 + pc-bios/optionrom/Makefile| 6 +- pc-bios/o