Re: [Qemu-devel] [PATCH v3] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
Thanks a lot for your all kind and helpful comments. I would fix it by myself to save the time of maintainer :) Then I have to beg your another review.BTW, I would like to ask if there's good tools or practice to perform an incremental review in qemu patch works. Thanks. Mark. On Wed 09

Re: [Qemu-devel] [PATCH v3] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Eric Blake
On 10/08/2013 08:39 PM, Mark Wu wrote: > In the original code, qmp_get_command_list is used to construct > a list of all commands' name. To get the information of all qga > commands, it traverses the name list and search the command info > with its name. So it can cause O(n^2) in the number of com

[Qemu-devel] [PATCH v3] Add interface to traverse the qmp command list by QmpCommand

2013-10-08 Thread Mark Wu
In the original code, qmp_get_command_list is used to construct a list of all commands' name. To get the information of all qga commands, it traverses the name list and search the command info with its name. So it can cause O(n^2) in the number of commands. This patch adds an interface to travers