Re: [Qemu-devel] [PATCH v2.1 3/3] chardev: introduce qemu_chr_timeout_add() and use

2018-01-04 Thread Stefan Hajnoczi
On Thu, Jan 04, 2018 at 10:31:58AM +0800, Peter Xu wrote: > On Wed, Jan 03, 2018 at 05:41:53PM +, Stefan Hajnoczi wrote: > > On Wed, Jan 03, 2018 at 10:24:18AM +0800, Peter Xu wrote: > > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > > > now can have dedicated gcont

Re: [Qemu-devel] [PATCH v2.1 3/3] chardev: introduce qemu_chr_timeout_add() and use

2018-01-03 Thread Peter Xu
On Wed, Jan 03, 2018 at 05:41:53PM +, Stefan Hajnoczi wrote: > On Wed, Jan 03, 2018 at 10:24:18AM +0800, Peter Xu wrote: > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > > now can have dedicated gcontext, we should always bind chardev tasks > > onto those gcontext r

Re: [Qemu-devel] [PATCH v2.1 3/3] chardev: introduce qemu_chr_timeout_add() and use

2018-01-03 Thread Stefan Hajnoczi
On Wed, Jan 03, 2018 at 10:24:18AM +0800, Peter Xu wrote: > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > now can have dedicated gcontext, we should always bind chardev tasks > onto those gcontext rather than the default main context. Since there > are quite a few of g_

Re: [Qemu-devel] [PATCH v2.1 3/3] chardev: introduce qemu_chr_timeout_add() and use

2018-01-03 Thread Marc-André Lureau
- Original Message - > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > now can have dedicated gcontext, we should always bind chardev tasks > onto those gcontext rather than the default main context. Since there > are quite a few of g_timeout_add[_seconds]() cal

[Qemu-devel] [PATCH v2.1 3/3] chardev: introduce qemu_chr_timeout_add() and use

2018-01-02 Thread Peter Xu
It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs now can have dedicated gcontext, we should always bind chardev tasks onto those gcontext rather than the default main context. Since there are quite a few of g_timeout_add[_seconds]() callers, a new function qemu_chr_timeout_a