Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Eric Blake
On 7/5/19 4:31 AM, Max Reitz wrote: > On 04.07.19 00:47, Eric Blake wrote: >> Although you generally won't use encryption with a Unix socket (after >> all, everything is local, so why waste the CPU power), there are >> situations in testsuites where Unix sockets are much nicer than TCP >> sockets.

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 05:47:07PM -0500, Eric Blake wrote: > +== check TLS works over Unix == > +image: nbd+unix://?socket=SOCKET > +file format: nbd > +virtual size: 64 MiB (67108864 bytes) > +disk size: unavailable > +image: nbd+unix://?socket=SOCKET > +file format: nbd > +virtual size: 64 MiB

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 11:31:51AM +0200, Max Reitz wrote: > On 04.07.19 00:47, Eric Blake wrote: > > diff --git a/tests/qemu-iotests/233.out b/tests/qemu-iotests/233.out > > index 9b46284ab0de..b86bee020649 100644 > > --- a/tests/qemu-iotests/233.out > > +++ b/tests/qemu-iotests/233.out > > [.

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 05:47:07PM -0500, Eric Blake wrote: > Although you generally won't use encryption with a Unix socket (after > all, everything is local, so why waste the CPU power), there are > situations in testsuites where Unix sockets are much nicer than TCP > sockets. Since nbdkit allow

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-05 Thread Max Reitz
On 04.07.19 00:47, Eric Blake wrote: > Although you generally won't use encryption with a Unix socket (after > all, everything is local, so why waste the CPU power), there are > situations in testsuites where Unix sockets are much nicer than TCP > sockets. Since nbdkit allows encryption over both

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703224707.12437-1-ebl...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make d

[Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

2019-07-03 Thread Eric Blake
Although you generally won't use encryption with a Unix socket (after all, everything is local, so why waste the CPU power), there are situations in testsuites where Unix sockets are much nicer than TCP sockets. Since nbdkit allows encryption over both types of sockets, it makes sense for qemu-nbd